Add workflow to test code coverage and generate coverage report#24
Merged
stevenhartley merged 6 commits intoeclipse-uprotocol:mainfrom Apr 11, 2024
neelam-kushwah:main
Merged
Add workflow to test code coverage and generate coverage report#24stevenhartley merged 6 commits intoeclipse-uprotocol:mainfrom neelam-kushwah:main
stevenhartley merged 6 commits intoeclipse-uprotocol:mainfrom
neelam-kushwah:main
Conversation
This commit adds a GitHub Actions workflow (`coverage.yml`) . The workflow runs on pull requests targeting the `main` branch and consists of a job named `test-and-coverage`. The job runs tests with coverage enabled, generates an HTML coverage report, and uploads the report as an artifact. Additionally, the workflow extracts the pull request title and description and comments on the pull request with the coverage results.
Contributor
Author
@stevenhartley |
With these new tests, we were able to increase code coverage to 98%. Along with this, we provided some linting improvements, as well as fixed a few methods that were implemented incorrectly in a previous PR.
Current system does not support tool.coverage.report, so I have removed it for now. Those exclusion cases will be covered in the coverage.rc file
matthewd0123
approved these changes
Apr 10, 2024
Contributor
Author
|
Commenting on PR is a known issue and limitation of GitHub actions when running for pull requests coming from a fork, see https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/4527#note_2084764 |
|
Per offline discussion, the open issue with adding notes to the PR will be addressed in a subsequent issue |
This was
linked to
issues
Jul 31, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #4 , #23 which is to add a GitHub Actions workflow (
coverage.yml) . The workflow runs on pull requests targeting themainbranch and consists of a job namedtest-and-coverage. The job runs tests with coverage enabled, generates an HTML coverage report, and uploads the report as an artifact. Additionally, the workflow comments on the pull request with the coverage results.